Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #256

Conversation

Tanmayi03
Copy link

@Tanmayi03 Tanmayi03 commented May 12, 2020

Description

'Goals of this project' section display of Github pages is fixed

Fixes #247

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@vinitshahdeo

Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any significant changes here, please explain what were you trying to do here to solve the issue?

@Tanmayi03
Copy link
Author

@PragatiVerma18, I added space between two words in two lines hoping that it resolves the given issue. Please correct and help me if I am wrong

@nandikajain
Copy link
Contributor

There are not enough and significant changes to merge this PR.
and the current form is readable to merge this PR.
If you can find other changes to be done, raise another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants