Changed React import to * from React #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @eternalconcert, Thank you for the PR. Can you please let me know in which version did you encounter this issue? |
|
Hi @vinothpandian, I came across this issue in the currently released version 5.3.4 as well as in a build from the latest sources. |
|
Thank you @eternalconcert. Unfortunately, I made a silly mistake of publishing and retracting v6 so the codebase is not up to date. Merge your PR once I clean it up! |
|
Is this going to be implemented in version 5.x.x.x? I am too trying v5.3.4, with the same issue. |
|
@eternalconcert Thanks again for the PR @StevenDeRoover v6 is taking more time than I expected. I have merged this PR and released it as v5.3.5 |
|
@vinothpandian lots of thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
When I tried the examples, I got the error
TS2786: 'ReactSketchCanvas' cannot be used as a JSX component.
Its instance type 'ReactSketchCanvas' is not a valid JSX element.
Type 'ReactSketchCanvas' is missing the following properties from type 'ElementClass': context, setState, forceUpdate, props, and 2 more
I am using
typescript 4.3.5
React 17.0.2
Node 16.5.0
With these small changes, the errors are gone.