Refactor: configurable BigQuery offline store export parquet file size #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjurkus
approved these changes
Nov 8, 2023
vstrimaitis
approved these changes
Nov 8, 2023
GytisBraz
approved these changes
Nov 8, 2023
| @@ -571,27 +573,16 @@ def to_remote_storage(self) -> List[str]: | |||
| "offline store when executing `to_remote_storage()`" | |||
| ) | |||
|
|
|||
| table = self.to_bigquery() | |||
| assert isinstance(self.config.offline_store, BigQueryOfflineStoreConfig) | |||
There was a problem hiding this comment.
is this for type checking? Why wasn't this needed before?
There was a problem hiding this comment.
Yes and getting autocompletion from IDE with field names. It is done the same way in another method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the corrected version:
This PR refactors the previous method of specifying the BigQuery export file size through an environment variable. The new implementation utilizes
BigQueryOfflineStoreConfig, allowing the configuration of the GCS staging file size directly via the Feast configuration file.An example of cofig: