Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discarded Draft #7

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Discarded Draft #7

merged 6 commits into from
Oct 18, 2023

Conversation

danielsalvador
Copy link

@danielsalvador danielsalvador commented Oct 18, 2023 •
edited
Loading

  • Enabled fetching the SQL Registry password from the environment variable FEAST_SQL_REGISTRY_PASSWORD
    • sdk/python/feast/infra/registry/sql.py
  • Fixed SQL query parsing bug in pull_latest_from_table_or_query, for PostgreSQLOfflineStore
    • sdk/python/feast/infra/offline_stores/contrib/postgres_offline_store/postgres.py
  • Compiled and added protos to the branch in order to be able to install the package from the repo

@danielsalvador danielsalvador requested a review from a team October 18, 2023 08:18
@danielsalvador danielsalvador changed the title Enable fetching the SQL Registry password from an environment variable Draft Oct 18, 2023
@danielsalvador danielsalvador merged commit 86126d4 into ml_platfrom_v034 Oct 18, 2023
15 of 17 checks passed
@danielsalvador danielsalvador changed the title Draft Discarded Draft Oct 18, 2023
@mjurkus mjurkus deleted the feature/get_registry_creds_from_env branch October 18, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danielsalvador