receive: expanded postings fixes #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase hash seed size. Perhaps in prod we have more than 1 million unique metric names in some tenant(-s)? - Add test that fuzzes queries against two receivers. One of them has expanded postings cache enabled. - Use fnv1a instead of xxhash like in Cortex. Perhaps fnv1a has a more uniform distribution? Not really sure why that would have any impact. Also, I've tested this in prod with some ad-hoc feature flag functionality through os.Stat(). Cannot see any impact anymore. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
expandedpostings_fixes
branch
from
07fd124 to
912b961
Compare
u1630022
reviewed
Dec 9, 2024
| for _, m := range ms { | ||
| if m.Name == labels.MetricName && m.Type == labels.MatchEqual { | ||
| return m.Value, true | ||
| if metricName != "" { | ||
| return "", false |
There was a problem hiding this comment.
The intention here is to return "", false if two Matchers match the given metric name?
There was a problem hiding this comment.
The purpose is to not cache if there more than two matchers on __name__. Technically such queries don't make sense and will never return results but just in case to avoid filling the cache with empty items
u1630022
approved these changes
Dec 9, 2024
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, I've tested this in prod with some ad-hoc feature flag functionality through os.Stat(). Cannot see any impact anymore.