query: add experimental Select() cache #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add experiment support for caching select() requests. Only local tests for now. Cache works on matching identical request signatures. Data is cached only on io.EOF error; if something else occurs then the response is not cached. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
v0.29.0+vinted_caching_exp
branch
from
462632b to
6f22322
Compare
Titasp
reviewed
Dec 14, 2022
| "github.com/thanos-io/thanos/pkg/tls" | ||
| "github.com/thanos-io/thanos/pkg/tracing" | ||
| ) | ||
|
|
||
| // StoreClientGRPCOpts creates gRPC dial options for connecting to a store client. | ||
| func StoreClientGRPCOpts(logger log.Logger, reg *prometheus.Registry, tracer opentracing.Tracer, secure, skipVerify bool, cert, key, caCert, serverName string) ([]grpc.DialOption, error) { | ||
| func StoreClientGRPCOpts(logger log.Logger, reg *prometheus.Registry, tracer opentracing.Tracer, secure, skipVerify bool, cert, key, caCert, serverName string, maxCacheSize model.Bytes) ([]grpc.DialOption, error) { |
There was a problem hiding this comment.
Style question, wouldn't it be better to refactor long function like this? (so that you wouldn't need to use horizontal slider to see all function params 😄 )
func StoreClientGRPCOpts(
logger log.Logger,
reg *prometheus.Registry,
tracer opentracing.Tracer,
secure, skipVerify bool,
cert, key, caCert, serverName string,
maxCacheSize model.Bytes,
) ([]grpc.DialOption, error) {
//...
}| } | ||
| } | ||
|
|
||
| var fetchKeys = make([]string, 0, numKeys) |
There was a problem hiding this comment.
style nit: var fetchKeys = ... -> fetchKeys := make([]string, 0, numKeys) ?
GiedriusS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add experiment support for caching select() requests. Only local tests for now. Cache works on matching identical request signatures. Data is cached only on io.EOF error; if something else occurs then the response is not cached.
Signed-off-by: Giedrius Statkevičius giedrius.statkevicius@vinted.com