Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: draft for vtgate boost query checks #8

Conversation

benetis
Copy link
Collaborator

@benetis benetis commented Mar 26, 2024

Following on our sync:

I've added boost config to be part of the engine.Plan. So in https://github.com/vinted/vitess/pull/8/files#diff-19aa815da9f21f65b55cc865090e2cefa77af98b30b134936853f7763898d255R123 we can do dirty check if its boosted and do redis query instead. However, since whole plan is available – we can also continue with vitess query. And since this function returns query result itself in last line – I think it could work as we would save the result in variable, put it in redis and then return result itself.
I think for a hacky quick solution – could be doable

Draft version, no tests and so on to enable us working together on this

@benetis benetis changed the title boost: draft for boost executor boost: draft for vtgate boost query checks Mar 27, 2024
@benetis benetis marked this pull request as ready for review March 27, 2024 09:00
@benetis benetis merged commit 83dcd06 into origin/vinted/11-0-4-backport-11-boost Mar 27, 2024
21 of 151 checks passed
@benetis benetis deleted the vinted/zygis/boost-executor-wip-draft2 branch March 27, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants