feat: async add new address to electrum #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Davidson-Souza
changed the title
Davidson-Souza
changed the title
Davidson-Souza
force-pushed
the
electrum-rescan
branch
from
a81f094 to
5c22286
Compare
Davidson-Souza
changed the title
Davidson-Souza
force-pushed
the
electrum-rescan
branch
3 times, most recently
from
b160a7e to
f44622d
Compare
We use this to tell an address isn't cached yet.
If a client subscribes an address that we haven't cached yet, add this to our wallet and try to find historical transactions for it
Davidson-Souza
force-pushed
the
electrum-rescan
branch
from
f44622d to
19d35d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, one needs to explicitly add a new address to the watch-only wallet and trigger a rescan, effectively downloading all blocks again. Now that we have compact block filters, we can make this way more efficiently.
The goal here's to allow the electrum server to rescan and find transactions from newly added addresses (e.g. addresses that were subscribed by a wallet, but aren't part of our watch-only wallet yet). With this feature, there's no need to extract the wallet's xpub or descriptors before starting using
floresta.PSA: this pr already builds on top of #108