Functional tests for floresta-wire/sync-node

[lla-dane]

Simulated a peer to take in requests for the sync-node instance. Filled the chain-state with some block-headers prior block validation and then send the appropriate responses to the node.

[lla-dane]

@Davidson-Souza, please suggest some more scenarios to test like you did for chain-selector, if needed.

[Davidson-Souza]

@Davidson-Souza, please suggest some more scenarios to test like you did for chain-selector, if needed.

The sync node is very simple, so I don't think there's much to test. But some things I can think of:

• Test how it responds to a node sending a block without proof (this should ban the node)
• How it responds to a block with invalid proof (this should ban the node, but should not invalidate the block)
• Sending blocks out-of-order (it should handle them fine)
• Sending duplicated blocks (this will increase the peer's ban score)

[Davidson-Souza]

Btw. The test_utils mod is the same code from #180 right? If you prefer, you can make one PR creating a module floresta-wire/src/p2p-wire/tests/util.rs and then rebase both this and #180 on that.

[lla-dane]

Btw. The test_utils mod is the same code from #180 right? If you prefer, you can make one PR creating a module floresta-wire/src/p2p-wire/tests/util.rs and then rebase both this and #180 on that.

Sure, I will do that.

[lla-dane]

The sync node is very simple, so I don't think there's much to test. But some things I can think of:

• Test how it responds to a node sending a block without proof (this should ban the node)
• How it responds to a block with invalid proof (this should ban the node, but should not invalidate the block)
• Sending blocks out-of-order (it should handle them fine)

Added these tests, and fixed a bug along the way #203. After merge of #203, I will rebase this.
@Davidson-Souza please take a look, and suggest if I have to change something, then I will squash these commits.

[lla-dane]

phew, I guess I am done with this PR, please take a look @Davidson-Souza !!

[Davidson-Souza]

Just a few minor things, in general looks great!

[lla-dane]

@Davidson-Souza, please take a look, if this PR is ready for merge.