Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused maybe_reindex #246

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Remove unused maybe_reindex #246

merged 1 commit into from
Oct 3, 2024

Conversation

JoseSK999
Copy link
Contributor

In #234 the maybe_reindex FullyValid match case was removed, so calling it for a FullyValid header doesn't do anything. Changed maybe_reindex to use an if let instead.

@Davidson-Souza
Copy link
Collaborator

Hmm, that makes sense. I've added that to handle some weird cases, where the validation index jumps back for some reason, but I've ran it after #234 and didn't have any problem. I think it's hard/impossible to get this to happen.

ACK 4721319

@Davidson-Souza Davidson-Souza merged commit 6467f2d into vinteumorg:master Oct 3, 2024
6 checks passed
@JoseSK999 JoseSK999 deleted the useless-maybe-reindex branch October 3, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoseSK999 @Davidson-Souza