Fix on allow-hostnames #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaoleal
force-pushed
the
fix-hostnames
branch
from
73dd9a7 to
b27cec1
Compare
|
satisfacting clippy and pre-commit with some typos |
|
ACK b27cec1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#286 (comment)
As mentioned in this comment the hostanames features was relying on a feature gate on windows (only on tests). Instead, i made the
resolve_connect_hostfunction to always specificate localhost while setting the ipv4.... This change was tested and developed on a native windows system.This change adds the following behavior to hostnames: "When no ip is specificated, floresta will try to use 127.0.0.1"