Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sc-59294] Creating the httpscaledobject file for the Keda project #127

Merged
merged 43 commits into from
Apr 24, 2023

Conversation

rlinstorres
Copy link
Contributor

@rlinstorres rlinstorres commented Mar 27, 2023

https://app.shortcut.com/findhotel/story/59294/research-and-poc-a-way-to-sleep-and-wake-pods-for-review-envs

By using the Keda project to handle the HTTP request in our Review Environments, we don't need to take care of an ingress setting per each review environment because it should be moved to the keda namespace where we will have a wildcard covering all review environments then per each environment we just need to have an HTTPScaledObject where keda needs to collect metrics to scaling up/down the environment checking the HTTP requests.

@shortcut-integration
Copy link

@rlinstorres rlinstorres requested a review from a team March 27, 2023 14:11
@rlinstorres rlinstorres self-assigned this Mar 27, 2023
@rlinstorres rlinstorres marked this pull request as draft March 27, 2023 14:11
@rlinstorres rlinstorres marked this pull request as ready for review March 30, 2023 16:05
@rlinstorres rlinstorres changed the title [sc-59294] Creaging the httpscaledobject file the for Keda project [sc-59294] Creaging the httpscaledobject file for the Keda project Mar 30, 2023
@rlinstorres rlinstorres changed the title [sc-59294] Creaging the httpscaledobject file for the Keda project [sc-59294] Creating the httpscaledobject file for the Keda project Mar 31, 2023
@rlinstorres rlinstorres marked this pull request as draft April 4, 2023 14:13
Copy link
Contributor

@victorpoluceno victorpoluceno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. Besides those, I missing update the docs about adding instruction on how to install keda and how to use or no kead.

@rlinstorres
Copy link
Contributor Author

I left some comments. Besides those, I missing update the docs about adding instruction on how to install keda and how to use or no kead.

Sure, I will update our docs.

@rlinstorres rlinstorres requested review from victorpoluceno and a team April 6, 2023 21:24
@rlinstorres rlinstorres marked this pull request as ready for review April 6, 2023 21:24
@rlinstorres rlinstorres marked this pull request as draft April 11, 2023 10:13
@rlinstorres rlinstorres marked this pull request as ready for review April 18, 2023 11:47
Copy link
Contributor

@victorpoluceno victorpoluceno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rlinstorres rlinstorres merged commit de5e244 into master Apr 24, 2023
@rlinstorres rlinstorres deleted the sc-59294 branch April 24, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants