-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sc-59294] Creating the httpscaledobject file for the Keda project #127
Conversation
This pull request has been linked to Shortcut Story #59294: Research and PoC a way to sleep and wake pods for review envs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. Besides those, I missing update the docs about adding instruction on how to install keda and how to use or no kead.
Sure, I will update our docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome.
Kudos, SonarCloud Quality Gate passed!
|
https://app.shortcut.com/findhotel/story/59294/research-and-poc-a-way-to-sleep-and-wake-pods-for-review-envs
httpscaledobject.yml
file created;Ref.: https://github.com/kedacore/http-add-on/blob/main/docs/ref/v0.2.0/http_scaled_object.md
kustomization.yaml
file updated by adding a newpatch
setting and thehttpscaledobject
file;ingress.yaml
file removed;KUSTOMIZE_VERSION
updated tov5.0.1
;KUBECTL_VERSION
updated tov1.24.11
;By using the
Keda project
to handle theHTTP
request in ourReview Environments
, we don't need to take care of aningress setting
per each review environment because it should be moved to thekeda namespace
where we will have awildcard
covering all review environments then per each environment we just need to have anHTTPScaledObject
where keda needs to collect metrics toscaling up/down
the environment checking the HTTP requests.