Validate the timeframe value (#19)

violinist-dev · Aug 8, 2022 · 22e7b98 · 22e7b98
1 parent 97d4a63
commit 22e7b98
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Config.php b/src/Config.php
@@ -122,6 +122,11 @@ public function getTimeFrameDisallowed()
         if (empty($this->config->timeframe_disallowed)) {
             return '';
         }
+        $frame = $this->config->timeframe_disallowed;
+        $length = count(explode('-', $frame));
+        if ($length !== 2) {
+            throw new \InvalidArgumentException('The timeframe should consist of two 24 hour format times separated by a dash ("-")');
+        }
         return $this->config->timeframe_disallowed;
     }
 

diff --git a/tests/UnitTest.php b/tests/UnitTest.php
@@ -129,9 +129,12 @@ public function testTimezone($filename, $expected_result)
      *
      * @dataProvider getTimeframes
      */
-    public function testTimeframeDisallowed($filename, $expected_result)
+    public function testTimeframeDisallowed($filename, $expected_result, $throws = false)
     {
         $data = $this->createDataFromFixture($filename);
+        if ($throws) {
+              $this->expectException(\InvalidArgumentException::class);
+        }
         self::assertEquals($expected_result, $data->getTimeFrameDisallowed());
     }
 
@@ -545,6 +548,7 @@ public function getTimeframes()
             [
                 'timeframe_disallowed4.json',
                 'does not really work, but value allowed',
+                true,
             ],
         ];
     }