Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Git-based dependencies not working through PyPi install #754

Closed
botherder opened this issue Aug 3, 2019 · 8 comments
Closed

Git-based dependencies not working through PyPi install #754

botherder opened this issue Aug 3, 2019 · 8 comments
Assignees
Labels
bug (verified) Bug that has been verified help wanted This is something we need some help with
Milestone

Comments

@botherder
Copy link
Member

While using pip3 install . inside Viper's folder works fine, installing through PyPi does not work and fails with the following error:

ERROR: Could not find a version that satisfies the requirement PyTaxonomies (from viper-framework) (from versions: none)
ERROR: No matching distribution found for PyTaxonomies (from viper-framework)

We need to investigate how to make this work, so we can wrap up 2.0 and finally release on PyPi.

@botherder botherder added bug (verified) Bug that has been verified help wanted This is something we need some help with labels Aug 3, 2019
@Rafiot
Copy link
Contributor

Rafiot commented Aug 5, 2019

Hmmm right, I need to do an actual release on PyPi then.

I'll work on it asap. When do you want to tag v2.0? The dirty fast fix is to make that optional: none of the git-based deps are critical.

@botherder
Copy link
Member Author

I'd prefer to figure out a way to make it work, cause I imagine other dependencies that are not MISP-related will cause the same issue.

@botherder botherder added this to the 2.0 milestone Nov 10, 2019
@botherder botherder reopened this Nov 10, 2019
@botherder
Copy link
Member Author

botherder commented Nov 10, 2019

I thought I had resolved, but this is still not working when uploading to PyPi:

HTTPError: 400 Client Error: Invalid value for requires_dist. Error: Can't have direct dependency: 'PyMISPGalaxies @ git+https://github.com/MISP/PyMISPGalaxies.git#egg=PyMISPGalaxies' for url: https://upload.pypi.org/legacy/

@botherder
Copy link
Member Author

Ultimately I think we can't have a PyPi package that depends on non-PyPi packages.

@botherder botherder pinned this issue Nov 10, 2019
@Rafiot
Copy link
Contributor

Rafiot commented Nov 11, 2019

You're probably right.

I really need to packages these dependencies. But as I cannot really give a timeline for that, I'll probably make these ones optional so we can release a package.

@botherder
Copy link
Member Author

What do you think about #767. In that way we could keep a viper package to a core, and then use git+pip commands from Viper to download and install modules.

@Rafiot
Copy link
Contributor

Rafiot commented Nov 11, 2019

Yep, 100% agree.

@botherder
Copy link
Member Author

Closing this ticket as I started work on #767.

@botherder botherder unpinned this issue Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug (verified) Bug that has been verified help wanted This is something we need some help with
Projects
None yet
Development

No branches or pull requests

2 participants