Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Should we split up different components? #767

Open
botherder opened this issue Nov 10, 2019 · 6 comments
Open

Should we split up different components? #767

botherder opened this issue Nov 10, 2019 · 6 comments
Assignees
Milestone

Comments

@botherder
Copy link
Member

As I go through the code-base, I can't help but feeling it is cluttered. I am wondering if it could make sense to try to separate essential components of the software.

For example, I'm thinking:

  1. Maintain the current repository for the essential core and CLI.
  2. Move all modules to a dedicated repository, and a command to the CLI to pull module updates. This (similarly to how we've done with Cuckoo), might also help reducing the need to regularly update the software itself and be more flexible on the packaging and distribution.
  3. Move the web interface to a dedicated repository.

Thoughts?

@botherder botherder self-assigned this Nov 10, 2019
@emdel
Copy link
Member

emdel commented Nov 10, 2019

I totally agree with you. We should have the essential core and the CLI core and I would say some core modules. Additional modules should go to the 'community' repository and the final user decides what to do.

@Rafiot
Copy link
Contributor

Rafiot commented Nov 11, 2019

This is a good approach, the problem being to decide what core and what isn't.

And definitely the web interface should be a dedicated repository, it will also be a lot easier to maintain issues related to it.

@botherder
Copy link
Member Author

botherder commented Nov 11, 2019

I did a first attempt at this and it is committed now.
Now modules are located at:
https://github.com/viper-framework/viper-modules/
And the web interface is located at:
https://github.com/viper-framework/viper-web/

I uploaded a package of the viper core to PyPi, as viper-framework, so it can now be installed with pip3 install viper-framework.
I also added an update-modules command that is just a first draft (it needs a lot of work), which pulls modules from git.

@botherder
Copy link
Member Author

@Rafiot I could use your help fixing up the repositories there and the installation of various dependencies.

@botherder botherder added this to the 2.0 milestone Nov 11, 2019
@Rafiot
Copy link
Contributor

Rafiot commented Nov 11, 2019

I'll try to get some work done on that this week (the 3 weeks after that will be difficult).

@Rafiot
Copy link
Contributor

Rafiot commented Mar 24, 2020

That should be fixed now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants