Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode layers; extract permissions to the underlying buffer from memory predicates #166

Merged
merged 16 commits into from
Feb 7, 2023
Merged

Decode layers; extract permissions to the underlying buffer from memory predicates #166

merged 16 commits into from
Feb 7, 2023

Conversation

jcp19
Copy link
Contributor

@jcp19 jcp19 commented Feb 7, 2023 •
edited
Loading

TODO:

  • decodeLayers with proper functional spec
  • make path specs tighter (same for its implementations)
  • re-format code

Note for the reviewer:

  • Currently, the dataplane is still under modification, do not look at it yet
  • all other packages are unlikely to change - please be careful in the review of these PRs, as they introduce a new way of structuring the predicates of the scion layers

I will merge this for now and latter I will provide a more complete functional specification for decodeLayers

This was referenced Feb 7, 2023
Closed
Closed
@jcp19 jcp19 linked an issue Feb 7, 2023 that may be closed by this pull request
Design Proposal: move ownership of underlying slices to outside of the Mem() predicate... #117
Closed
@jcp19 jcp19 mentioned this pull request Feb 7, 2023
Closed
@jcp19 jcp19 requested a review from Dspil February 7, 2023 15:23
@jcp19 jcp19 marked this pull request as ready for review February 7, 2023 17:57
@jcp19 jcp19 merged commit 4516a0e into master Feb 7, 2023
@jcp19 jcp19 deleted the joao-decode-layers branch February 7, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dspil Dspil Dspil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design Proposal: move ownership of underlying slices to outside of the Mem() predicate...
2 participants
@jcp19 @Dspil