Verify core of Run method
#240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oop (almost done)
Closed
jcp19
changed the title
Run method - very experimental branchRun method
Dspil
approved these changes
Jan 26, 2024
| outputCounters := d.forwardingMetrics[result.EgressID] | ||
| // @ assert acc(outputCounters.OutputPacketsTotal.Mem(), _) |
There was a problem hiding this comment.
Are these asserts that just check for a permission amount to a predicate necessary?
There was a problem hiding this comment.
They are not necessary, but I found them useful for debugging whenever I was converging to the specs. With this, I can find immediately whenever some expectation is broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifies and verifies the method (*DataPlane).Run(...). This PR shows that the main loop of the router, which starts a thread per interface of the router which receives, processes, and sends packets is memory safe.
In the process, we ironed out our specification style to make Gobra scale to the challenge and to make the specs more readable
TODO:
assume falseinprocessPktassume falseinprocessOHPconcluded in 9f324c8)(*DataPlane).Run(...)(may be done in a separate PR, this one is already quite large)