show term ID is now responsive in explain path #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -507,10 +507,6 @@ private void pathExplanationButton_Click(object sender, EventArgs e) | |||
| highlightPath(cyclePath); | |||
| _z3AxiomProfiler.UpdateSync(cyclePath); | |||
| toRemove = cyclePath.GetInstnationsUnusedInGeneralization(); | |||
| if (cyclePath.NeedsIds()) | |||
There was a problem hiding this comment.
Out of interest, when does this function return true?
There was a problem hiding this comment.
NeedsIds() is true when CycleDetection.NeedsIds is true, explained in the other conversation
| @@ -561,10 +561,6 @@ private void printCycleInfo(InfoPanelContent content, PrettyPrintFormat format) | |||
| if (!hasCycle()) return; | |||
| var cycle = cycleDetector.getCycleQuantifiers(); | |||
| var generalizationState = cycleDetector.getGeneralization(); | |||
| if (generalizationState.NeedsIds) | |||
There was a problem hiding this comment.
When is this field set to true in the current code? Is it used for anything else?
There was a problem hiding this comment.
This field is not used anywhere else.
CycleDetection.NeedsIds is true when:
- no generalization has been found for the first term nor the last term of the generalized loop
- the first term and the last term of the generalized loop has no dependent term
- the loop contains more than one term
This can be found in CycleDetection.MarkGeneralizations
(the conditions above are only what I interpreted from the code, it is unclear to me what is the higher-level semantics of NeedsIds)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves issue #17
@alexanderjsummers
'show term id' now is responsive during explain path, and is by default off