-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate the usage of the SilFrontend API and support for the refute statement #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArquintL
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As suggested, I've looked at the 3 not yet reviewed files and have a minor wish if it does not take too long to implement besides 3 suggestions for a bit more documentation or typo fixes. Otherwise, looks good! Thanks for this PR! =)
Co-authored-by: Linard Arquint <ArquintL@users.noreply.github.com>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reinstates the changes by Lea 🍔 (@bruggerl) introduced in PR #776. To make sure that there are no feature regressions in Gobra, we should only merge this when
(Add support for chopping programs before the Termination plugin runs silver#832 - might not be the best solution, we shall see)In addition to all the fixes listed in PR #776, this PR now also fixes a bug where the option
--respectFunctionPrePermAmounts
(introduced in PRs and ) is not properly communicated to the backend, as prior to this PR, we called the TerminationPlugin directly, and passed a wrong SilFrontendConfig objectDepends on #819.
Note to the reviewer: The only non-reviewed changes introduced by this PR are in the
PluginAwareChopper
and its tests, and in theChopperUtil
file