Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate the usage of the SilFrontend API and support for the refute statement #818

Merged
merged 8 commits into from
Jan 16, 2025

Conversation

jcp19
Copy link
Contributor

@jcp19 jcp19 commented Jan 10, 2025

This PR reinstates the changes by Lea 🍔 (@bruggerl) introduced in PR #776. To make sure that there are no feature regressions in Gobra, we should only merge this when

In addition to all the fixes listed in PR #776, this PR now also fixes a bug where the option --respectFunctionPrePermAmounts (introduced in PRs and ) is not properly communicated to the backend, as prior to this PR, we called the TerminationPlugin directly, and passed a wrong SilFrontendConfig object

Depends on #819.

Note to the reviewer: The only non-reviewed changes introduced by this PR are in the PluginAwareChopper and its tests, and in the ChopperUtil file

@jcp19 jcp19 marked this pull request as ready for review January 12, 2025 19:23
@jcp19 jcp19 requested a review from bruggerl January 12, 2025 19:34
@jcp19 jcp19 requested a review from ArquintL January 12, 2025 21:54
Copy link
Member

@ArquintL ArquintL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested, I've looked at the 3 not yet reviewed files and have a minor wish if it does not take too long to implement besides 3 suggestions for a bit more documentation or typo fixes. Otherwise, looks good! Thanks for this PR! =)

jcp19 and others added 2 commits January 16, 2025 10:20
Co-authored-by: Linard Arquint <ArquintL@users.noreply.github.com>
@jcp19 jcp19 merged commit f164bc2 into master Jan 16, 2025
2 of 3 checks passed
@jcp19 jcp19 deleted the add-refute-again branch January 16, 2025 09:48
ArquintL added a commit that referenced this pull request Jan 17, 2025
ArquintL added a commit that referenced this pull request Jan 19, 2025
@jcp19 jcp19 mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants