-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure Prusti arguments and environment variables #139
Conversation
src/server.ts
Outdated
util.log(`Prusti server will be executed in '${prustiServerCwd}'`); | ||
} | ||
|
||
const prustiServerArgs = ["--port", "0"].concat( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, we could move the --port
setting to extraPrustiServerArgs
instead of hardcoding it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you see a use case for letting the user choose the port?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, but I don't see much of a reason for the --port
setting in the first place aha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah :D We could at least make 0 the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, in that case we can merge as is
Mmm, for some reason the prusti-server keeps failing on Windows. |
When I run the test on Windows I get:
As the output in |
I think that the error is caused by the leading |
9c3ad25
to
0b6212c
Compare
Thanks! Apparently, for disk operations one must use I added plenty of log to the console. Debugging should be easier. |
Hahaha, this github CI on all 3 platforms is invaluable |
In this PR:
prusti-rustc
,cargo-prusti
andprusti-server
. This mitigates Allow configuring the server #62.prusti-server
start in the first folder of the workspace. This way, if the user enablesPRUSTI_DUMP_VIPER_PROGRAM
, the dump will end up in the workspace and not in some obscure folder of VS Code.I haven't added a way to test that the new configuration options work as intended. I just tested them locally.