Ghost Type Encodings #181
Open
Ghost Type Encodings #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakaras
reviewed
Sep 23, 2020
vakaras
reviewed
Sep 23, 2020
vakaras
reviewed
Sep 23, 2020
aakp10
force-pushed
the
karuna/encoding-v2
branch
from
ed289bd to
33ac0c3
Compare
aakp10
commented
Sep 26, 2020
fpoli
reviewed
Sep 28, 2020
fpoli
reviewed
Sep 28, 2020
fpoli
reviewed
Sep 28, 2020
|
I totally agree that we should have some tests before merging. |
aakp10
force-pushed
the
karuna/encoding-v2
branch
from
9dc397c to
1c9ddc1
Compare
@vakaras @fpoli Thanks for the reviews, I've added a couple of type checking related test cases for the ghost types. I'll continue extending the test cases to accommodate the noninterference properties of ghost types with the upcoming changes that I'm currently working on. |
aakp10
force-pushed
the
karuna/encoding-v2
branch
3 times, most recently
from
5db62e1 to
f5de7f8
Compare
aakp10
force-pushed
the
karuna/encoding-v2
branch
2 times, most recently
from
cd6e20a to
3beeb22
Compare
aakp10
commented
Oct 10, 2020
aakp10
force-pushed
the
karuna/encoding-v2
branch
2 times, most recently
from
7976ee3 to
a27f3fd
Compare
aakp10
force-pushed
the
karuna/encoding-v2
branch
from
a27f3fd to
3895c62
Compare
vakaras
reviewed
Dec 23, 2020
vakaras
reviewed
Dec 23, 2020
vakaras
reviewed
Dec 23, 2020
vakaras
reviewed
Dec 23, 2020
vakaras
reviewed
Dec 23, 2020
vakaras
reviewed
Dec 23, 2020
vakaras
reviewed
Dec 23, 2020
Aurel300
force-pushed
the
karuna/encoding-v2
branch
from
acf1667 to
7ea498d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds encoding definitions for Ghost Types.