Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around AssertKind::description panicing for BoundsCheck #467

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Work around AssertKind::description panicing for BoundsCheck #467

merged 2 commits into from
Apr 21, 2021

Commits on Apr 21, 2021

  1. Work around AssertKind::description panicing for BoundsCheck 

    AssertKind::BoundsCheck panics on calling AssertKind::display, and the
docs say that the caller is supposed to handle those earlier[0]. So we
use the Debug impl instead, which can handle BoundsCheck.

At some point we want to switch to using `AssertKind::fmt_assert_args`,
but currently that is not public in rustc.

[0] https://doc.rust-lang.org/stable/nightly-rustc/rustc_middle/mir/enum.AssertKind.html#impl
    @dario23
    dario23 committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    391ad9c View commit details
    Browse the repository at this point in the history

  2. Add rustc PR number for making fmt_assert_args pub

    @dario23
    dario23 committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    bdcccad View commit details
    Browse the repository at this point in the history