Fix slice with range encoding #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasAlaif
force-pushed
the
fix-slice-indexing
branch
from
4dccc5d to
f6d4c70
Compare
JonasAlaif
force-pushed
the
fix-slice-indexing
branch
from
f6d4c70 to
b23b426
Compare
fpoli
reviewed
Apr 26, 2022
fpoli
approved these changes
Apr 26, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 27, 2022
Fixes #960 Issue is described there. Not sure if this is the correct way to do the error reporting? It would be really nice to just have a contract for `index` and `index_mut` and report the error as a precondition violation of those. E.g. I really don't want to hardcode the pledge required for `index_mut` by hand.
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 28, 2022
Fixes #960 Issue is described there. Not sure if this is the correct way to do the error reporting? It would be really nice to just have a contract for `index` and `index_mut` and report the error as a precondition violation of those. E.g. I really don't want to hardcode the pledge required for `index_mut` by hand.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Apr 28, 2022
Fixes #960 Issue is described there. Not sure if this is the correct way to do the error reporting? It would be really nice to just have a contract for `index` and `index_mut` and report the error as a precondition violation of those. E.g. I really don't want to hardcode the pledge required for `index_mut` by hand.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Apr 29, 2022
Fixes #960 Issue is described there. Not sure if this is the correct way to do the error reporting? It would be really nice to just have a contract for `index` and `index_mut` and report the error as a precondition violation of those. E.g. I really don't want to hardcode the pledge required for `index_mut` by hand.
|
Build failed: |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #960
Issue is described there. Not sure if this is the correct way to do the error reporting?
It would be really nice to just have a contract for
indexandindex_mutand report the error as a precondition violation of those. E.g. I really don't want to hardcode the pledge required forindex_mutby hand.