-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling non-linear integer arithmetics #783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few minor comments that we should address before merging. Could we also add a test that typically passes, but which should fail with the new flag to make sure that the implementation has the expected behaviour?
Co-authored-by: João Pereira <joaopereira.19@gmail.com>
Co-authored-by: João Pereira <joaopereira.19@gmail.com>
Co-authored-by: João Pereira <joaopereira.19@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I added a comment to address if possible though
We already have a flag to pass options to Z3, right? Is this just tomake it more convenient? |
Yes, it seems useful to have it as a separate option since we use it more and more (especially in scion) |
Okay, makes sense. Would be nice if you could make it work for Z3 API as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Adds a flag in silicon to disable non-linear integer arithmetics when Z3 via STDIO is used.