account for content wrapped in <p> tags & various fixes #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this plugin incredibly useful, until the content I was trying to shorten was user-generated from a wysiwyg. Most content gets wrapped in
<p>
tags, so it's not just 'floating.' This caused the plugin to break, as it didn't know how to properly handle them, as they were not tags within the text to be truncated, but rather wrapping the entirety of the content.This pull request does a few things:
<div>
tags for theshortcontent
andallcontent
wrappers (better semantically, as<p>
tags within<span>
tags is... weird)<p>
tag in shortcontent (so it actually appears cut off)<span>
with a class ofellip
so you can styleIf anyone has a better approach to account for
<p>
tags and other wrapping elements, share em in the comments.