Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response: fix some bugs of Response struct #53

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Xynnn007
Copy link
Contributor

@Xynnn007 Xynnn007 commented Dec 12, 2024

  1. In previous commits we did a duplicated base64 encoding and decoding when serializing/deserializing the AAD field. This patch fixes it.
  2. Extend ProtectedHeader to allow nested structues for EC suites.

In previous commits we did a duplicated base64 encoding and decoding
when serializing/deserializing the AAD field.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007 Xynnn007 marked this pull request as ready for review December 12, 2024 09:52
@Xynnn007 Xynnn007 changed the title AAD: fix serialization and deserialization logic Response: fix some bugs of Response struct Dec 13, 2024
For JWE using EC or ECX, the ephemeral asymmetric public key should be
included in the ProtectedHeader. It will be a nested structure rather
than flatten fields.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007 Xynnn007 force-pushed the fix-aad-serialization branch from e95eb8d to f56c565 Compare December 13, 2024 08:36
@Xynnn007 Xynnn007 marked this pull request as draft December 13, 2024 08:59
@Xynnn007 Xynnn007 marked this pull request as ready for review December 16, 2024 10:10
@Xynnn007
Copy link
Contributor Author

succeeded testing locally with confidential-containers/trustee#597 for JWE compability and confidential-containers/guest-components#820 for kbs-client/server resource access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants