Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ok: Expand coverage for all AMD CPU model numbers #43

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

tylerfanelli
Copy link
Member

@tylerfanelli tylerfanelli commented Jul 8, 2022

An AMD processor's generation can be found from the ID associated with the
processor.

For example:
A 1st generation (Naples processor) has an ID of 7xx1, where the lower "1"
indicates the first generation of EPYC processors. This is extended with each
new generation of AMD EPYC processor:

    Naples: 1 (SEV)
    Rome: 2 (SEV, SEV-ES)
    Milan: 3 (SEV, SEV-ES, SEV-SNP)

@tylerfanelli tylerfanelli requested review from crobinso and slp July 8, 2022 04:27
@dagrh
Copy link
Contributor

dagrh commented Jul 12, 2022

Looking down Wikipedia's list of EPYC models, https://en.wikipedia.org/wiki/Epyc,
what does this code do when run on a '7573X' or '72F3' ?
(Or a non-EPYC AMD cpu)

@dagrh
Copy link
Contributor

dagrh commented Jul 14, 2022

Looking down Wikipedia's list of EPYC models, https://en.wikipedia.org/wiki/Epyc, what does this code do when run on a '7573X' or '72F3' ? (Or a non-EPYC AMD cpu)

Actually, thinking about this, the right way to do this is to use the family/model ; I think tehy're pretty stable so you then get a whole bunch with one comparison

An AMD processor's generation can be found from the ID associated with the
processor.

For example:
A 1st generation (Naples processor) has an ID of 7xx1, where the lower "1"
indicates the first generation of EPYC processors. This is extended with each
new generation of AMD EPYC processor:

        Naples: 1 (SEV)
        Rome: 2 (SEV, SEV-ES)
        Milan: 3 (SEV, SEV-ES, SEV-SNP)

Signed-off-by: Tyler Fanelli <tfanelli@redhat.com>
@tylerfanelli tylerfanelli merged commit 90b62b6 into virtee:main Jul 28, 2022
@tylerfanelli tylerfanelli deleted the ok_model_coverage branch November 17, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants