Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding snpguest ok #47

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Adding snpguest ok #47

merged 2 commits into from
Mar 28, 2024

Conversation

arvindskumar99
Copy link
Contributor

Adding tests to make sure SEV, SEV-ES, and SNP are enabled in guest.

image

tylerfanelli
tylerfanelli requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@tylerfanelli tylerfanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For each test, [ PASS ] should tell you everything you need to know regarding the test unless there is some extra parameters to print.

With [ PASS ] SEV: SEV is enabled, the SEV is enabled part is irrelevant.

larrydewey
larrydewey requested changes Mar 8, 2024
View reviewed changes
src/ok.rs Outdated Show resolved Hide resolved
DGonzalezVillal
DGonzalezVillal requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@DGonzalezVillal DGonzalezVillal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of the logic can be more concise and effective, but you're on the right track!

src/ok.rs Outdated Show resolved Hide resolved
src/ok.rs Outdated Show resolved Hide resolved
src/ok.rs Outdated Show resolved Hide resolved
src/ok.rs Outdated Show resolved Hide resolved
src/ok.rs Outdated Show resolved Hide resolved
src/ok.rs Outdated Show resolved Hide resolved
@DGonzalezVillal
Copy link
Member

@arvindskumar99 please also modify the README and the docs

@arvindskumar99
Copy link
Contributor Author

@arvindskumar99 please also modify the README and the docs

Sounds good, I'll get started on those changes

@arvindskumar99
Copy link
Contributor Author

Made the suggested changes, here's how the results look now.

image

DGonzalezVillal
DGonzalezVillal requested changes Mar 15, 2024
View reviewed changes
src/ok.rs Outdated Show resolved Hide resolved
@arvindskumar99
Adding snpguest ok
4b362d8 
Signed-off-by: arvindskumar99 <arvinkum@amd.com>
larrydewey
larrydewey requested changes Mar 26, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
src/ok.rs Outdated Show resolved Hide resolved
src/ok.rs Outdated Show resolved Hide resolved
@arvindskumar99
Additional Features
a01a360 
Signed-off-by: arvindskumar99 <arvinkum@amd.com>
DGonzalezVillal
DGonzalezVillal approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@DGonzalezVillal DGonzalezVillal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@larrydewey larrydewey merged commit 9579368 into virtee:main Mar 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DGonzalezVillal DGonzalezVillal DGonzalezVillal approved these changes

@tylerfanelli tylerfanelli tylerfanelli approved these changes

@larrydewey larrydewey larrydewey approved these changes

Assignees

@tylerfanelli tylerfanelli

@DGonzalezVillal DGonzalezVillal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arvindskumar99 @DGonzalezVillal @larrydewey @tylerfanelli