Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the context message for failing to open SEV firmware. #50

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

yuuzi41
Copy link
Contributor

@yuuzi41 yuuzi41 commented Apr 12, 2024

As below, SEV-SNP guest firmware device file is usually /dev/sev-guest at present. thus it'd be better if the context message contained it.

https://github.com/virtee/sev/blob/v3.1.1/src/firmware/guest/mod.rs#L66

As below, SEV-SNP guest firmware device file is usually /dev/sev-guest. thus it'd be better if the context message contained it.

https://github.com/virtee/sev/blob/v3.1.1/src/firmware/guest/mod.rs#L66


Signed-off-by: Yuji Hagiwara <yuuzi41@gmail.com>
Copy link
Member

@tylerfanelli tylerfanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. LGTM.

@tylerfanelli tylerfanelli merged commit cc5f414 into virtee:main Apr 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants