Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MSRV to 1.80 #70

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Upgrade MSRV to 1.80 #70

merged 1 commit into from
Sep 6, 2024

Conversation

CookieComputing
Copy link
Contributor

Following our conversation in #69 (comment), upgrade the toolchain to 1.80 to keep up with the latest distro MSRV releases

It built for me here:

$ cargo build
warning: `/home/kevinhui/.cargo/config` is deprecated in favor of `config.toml`
note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
warning: `/home/kevinhui/.cargo/config` is deprecated in favor of `config.toml`
note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
   Compiling quote v1.0.37
   Compiling libc v0.2.158
   Compiling shlex v1.3.0
   Compiling serde v1.0.209
   Compiling unicode-xid v0.2.5
   Compiling tower-service v0.3.3
   Compiling indexmap v2.5.0
   Compiling cc v1.1.16
   Compiling syn v2.0.77
   Compiling syn v1.0.109
   Compiling openssl-src v300.3.2+3.3.2
   Compiling openssl-sys v0.9.103
   Compiling ring v0.16.20
   Compiling mio v1.0.2
   Compiling socket2 v0.5.7
   Compiling getrandom v0.2.15
   Compiling dirs-sys v0.4.1
   Compiling is-terminal v0.4.13
   Compiling nix v0.23.2
   Compiling env_logger v0.10.2
   Compiling dirs v5.0.1
   Compiling rand_core v0.6.4
   Compiling rdrand v0.8.3
   Compiling tokio v1.40.0
   Compiling serde_derive v1.0.209
   Compiling openssl-macros v0.1.1
   Compiling thiserror-impl v1.0.63
   Compiling displaydoc v0.2.5
   Compiling zerocopy-derive v0.7.35
   Compiling clap_derive v4.5.13
   Compiling synstructure v0.12.6
   Compiling zerocopy v0.7.35
   Compiling asn1-rs-impl v0.1.0
   Compiling asn1-rs-derive v0.4.0
   Compiling thiserror v1.0.63
   Compiling ppv-lite86 v0.2.20
   Compiling rand_chacha v0.3.1
   Compiling clap v4.5.17
   Compiling asn1-rs v0.5.2
   Compiling rand v0.8.5
   Compiling tokio-util v0.7.12
   Compiling h2 v0.3.26
   Compiling oid-registry v0.6.1
   Compiling der-parser v8.2.0
   Compiling x509-parser v0.14.0
   Compiling uuid v1.10.0
   Compiling bincode v1.3.3
   Compiling serde_bytes v0.11.15
   Compiling serde-big-array v0.5.1
   Compiling serde_urlencoded v0.7.1
   Compiling hyper v0.14.30
   Compiling openssl v0.10.66
   Compiling native-tls v0.2.12
   Compiling tokio-native-tls v0.3.1
   Compiling hyper-tls v0.5.0
   Compiling reqwest v0.11.27
   Compiling sev v4.0.0
   Compiling snpguest v0.6.0 (/home/kevinhui/snpguest)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.70s

CI signals should probably check if I've missed anything else

Signed-off-by: Kevin Hui <kevinhui@meta.com>
@CookieComputing
Copy link
Contributor Author

Huh. Not sure why clippy is failing to install, when https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-gnu.html implies that clippy should be present? I'll take a look when I have time

Copy link
Member

@tylerfanelli tylerfanelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I'll run clippy manually and make any necessary changes.

@tylerfanelli tylerfanelli merged commit 75bf4d5 into virtee:main Sep 6, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants