Pass ConfigInterface to SetAuthConfig method for mock

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
virtual-kubelet · Apr 13, 2023 · 1f5e08f · 1f5e08f
1 parent 54f09c6
commit 1f5e08f
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 10 deletions.
diff --git a/cmd/init-container/main.go b/cmd/init-container/main.go
@@ -60,7 +60,7 @@ func main() {
  azConfig := auth.Config{}
 
  //Setup config
- err = azConfig.SetAuthConfig(ctx)
+ err = azConfig.SetAuthConfig(ctx, &azConfig)
  if err != nil {
  log.G(ctx).Fatalf("cannot setup the auth configuration. Retrying, ", err)
  }

diff --git a/cmd/virtual-kubelet/main.go b/cmd/virtual-kubelet/main.go
@@ -97,7 +97,7 @@ func main() {
 
  var provider string
  //Setup config
- err := azConfig.SetAuthConfig(ctx)
+ err := azConfig.SetAuthConfig(ctx, &azConfig)
  if err != nil {
  log.G(ctx).Fatal(err)
  }

diff --git a/pkg/auth/auth_config.go b/pkg/auth/auth_config.go
@@ -109,7 +109,7 @@ func (c *Config) GetAuthorizer(ctx context.Context, resource string) (autorest.A
 }
 
 // SetAuthConfig sets the configuration needed for Authentication.
-func (c *Config) SetAuthConfig(ctx context.Context) error {
+func (c *Config) SetAuthConfig(ctx context.Context, configInterface ConfigInterface) error {
  ctx, span := trace.StartSpan(ctx, "auth.SetAuthConfig")
  defer span.End()
 
@@ -186,7 +186,7 @@ func (c *Config) SetAuthConfig(ctx context.Context) error {
 
  resource := c.Cloud.Services[cloud.ResourceManager].Endpoint
 
- c.Authorizer, err = c.GetAuthorizer(ctx, resource)
+ c.Authorizer, err = configInterface.GetAuthorizer(ctx, resource)
  if err != nil {
  return err
  }

diff --git a/pkg/auth/auth_config_test.go b/pkg/auth/auth_config_test.go
@@ -153,7 +153,7 @@ func TestSetAuthConfigWithAuthFile(t *testing.T) {
  }
 
  azConfig := Config{}
- err = azConfig.SetAuthConfig(context.TODO())
+ err = azConfig.SetAuthConfig(context.TODO(), &azConfig)
  if err != nil {
  t.Error(err)
  }
@@ -200,7 +200,7 @@ func TestSetAuthConfigWithAKSCredFile(t *testing.T) {
  }
 
  azConfig := Config{}
- err = azConfig.SetAuthConfig(context.TODO())
+ err = azConfig.SetAuthConfig(context.TODO(), &azConfig)
  if err != nil {
  t.Error(err)
  }
@@ -244,7 +244,7 @@ func TestSetAuthConfigWithEnvVariablesOnly(t *testing.T) {
  }
 
  azConfig := Config{}
- err = azConfig.SetAuthConfig(context.TODO())
+ err = azConfig.SetAuthConfig(context.TODO(), &azConfig)
  if err != nil {
  t.Error(err)
  }

diff --git a/pkg/network/aci_network_test.go b/pkg/network/aci_network_test.go
@@ -147,7 +147,7 @@ func TestSetupNetwork(t *testing.T) {
  networkMocks := NewMockProviderNetworkInterface(mockCtrl)
 
  azConfig := &auth.Config{}
- err := azConfig.SetAuthConfig(context.TODO())
+ err := azConfig.SetAuthConfig(context.TODO(), azConfig)
  if err != nil {
  t.Fatal(err)
  }

diff --git a/pkg/provider/aci_test.go b/pkg/provider/aci_test.go
@@ -688,7 +688,7 @@ func TestPodToACIEnvVar(t *testing.T) {
 }
 
 func setAuthConfig() error {
- err := azConfig.SetAuthConfig(context.TODO())
+ err := azConfig.SetAuthConfig(context.TODO(), &azConfig)
  if err != nil {
  return err
  }
@@ -1133,7 +1133,7 @@ func TestGetPodWithContainerID(t *testing.T) {
  mockPodsNamespaceLister.EXPECT().Get(podName).
  Return(testsutil.CreatePodObj(podName, podNamespace), nil)
 
- err := azConfig.SetAuthConfig(context.TODO())
+ err := azConfig.SetAuthConfig(context.TODO(), &azConfig)
  if err != nil {
  t.Fatal("failed to get auth configuration", err)
  }