Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recording events #470

Closed
hypnoce opened this issue Feb 27, 2023 · 0 comments · Fixed by #471
Closed

Recording events #470

hypnoce opened this issue Feb 27, 2023 · 0 comments · Fixed by #471
Assignees
@hypnoce
Labels
kind/feature

Comments

@hypnoce
Copy link
Contributor

hypnoce commented Feb 27, 2023 •
edited
Loading

Describe the request
ACI events (mount failure...) are propagated back to kubernetes.
This can greatly improve operability of azure-aci.
This feature has also been requested as part of the generic virtual-kuebelet project: virtual-kubelet/virtual-kubelet#443

Explain why azure-aci Plugin needs it
Events are being sent from ACI without being sent to kubernetes. Sometimes the container group completely fails to start without kubernetes being notified. This can ensure a minimum feedback by recording the ACI events and sending them to k8s.

Describe the solution you'd like
Azure-aci can implement itself event recording without relying on specific interface from virtual-kubelet.

Describe alternatives you've considered
use the az CLI

Additional context
hypnoce pushed a commit to hypnoce/azure-aci that referenced this issue Feb 27, 2023
Record ACI events back to kubernetes (virtual-kubelet#470)
1b86dca 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
hypnoce pushed a commit to hypnoce/azure-aci that referenced this issue Feb 27, 2023
Record ACI events back to kubernetes (virtual-kubelet#470)
934d46c 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
hypnoce pushed a commit to hypnoce/azure-aci that referenced this issue Mar 27, 2023
Record ACI events back to kubernetes (virtual-kubelet#470)
a192f12 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
hypnoce pushed a commit to hypnoce/azure-aci that referenced this issue Mar 27, 2023
Record ACI events back to kubernetes (virtual-kubelet#470)
0074c1c 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
hypnoce pushed a commit to hypnoce/azure-aci that referenced this issue Mar 27, 2023
Record ACI events back to kubernetes (virtual-kubelet#470)
6a28e6b 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
hypnoce pushed a commit to hypnoce/azure-aci that referenced this issue Mar 30, 2023
Record ACI events back to kubernetes (virtual-kubelet#470)
4b27fdb 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
hypnoce pushed a commit to hypnoce/azure-aci that referenced this issue Mar 30, 2023
Record ACI events back to kubernetes (virtual-kubelet#470)
3514450 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
hypnoce pushed a commit to hypnoce/azure-aci that referenced this issue Mar 30, 2023
Record ACI events back to kubernetes (virtual-kubelet#470)
13898fa 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
@helayoty helayoty linked a pull request Apr 11, 2023 that will close this issue
feat: record ACI events back to kubernetes (#470) #471
Merged
hypnoce pushed a commit to hypnoce/azure-aci that referenced this issue Apr 13, 2023
Record ACI events back to kubernetes (virtual-kubelet#470)
11749cd 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
hypnoce pushed a commit to hypnoce/azure-aci that referenced this issue Apr 13, 2023
Record ACI events back to kubernetes (virtual-kubelet#470)
3acd8e0 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
hypnoce pushed a commit to hypnoce/azure-aci that referenced this issue Apr 13, 2023
Record ACI events back to kubernetes (virtual-kubelet#470)
5ece04c 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
hypnoce pushed a commit to hypnoce/azure-aci that referenced this issue Apr 18, 2023
Record ACI events back to kubernetes (virtual-kubelet#470)
2cf99b9 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
hypnoce pushed a commit to hypnoce/azure-aci that referenced this issue Apr 20, 2023
Record ACI events back to kubernetes (virtual-kubelet#470)
4651c51 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
hypnoce pushed a commit to hypnoce/azure-aci that referenced this issue Apr 27, 2023
Record ACI events back to kubernetes (virtual-kubelet#470)
f9494c3 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
helayoty pushed a commit that referenced this issue May 4, 2023
@hypnoce
feat: record ACI events back to kubernetes (#470) (#471)
9e3a6db 
Signed-off-by: JACQUES Francois <Francois.JACQUES@murex.com>
Co-authored-by: JACQUES Francois <Francois.JACQUES@murex.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hypnoce hypnoce

Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: record ACI events back to kubernetes (#470) hypnoce/azure-aci
2 participants
@hypnoce @helayoty