Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ACI mocks #316

Merged
merged 1 commit into from
Oct 4, 2022
Merged

refactor: ACI mocks #316

merged 1 commit into from
Oct 4, 2022

Conversation

helayoty
Copy link
Member

@helayoty helayoty commented Oct 4, 2022 •
edited
Loading

  • Move the files from provider folder into pkg/provider.
  • Add mock_aci_test.go

@helayoty helayoty requested a review from Fei-Guo October 4, 2022 22:11
@helayoty helayoty temporarily deployed to test October 4, 2022 22:12 Inactive
@helayoty helayoty temporarily deployed to test October 4, 2022 22:12 Inactive
@helayoty helayoty mentioned this pull request Oct 4, 2022
Closed
11 tasks
@helayoty helayoty temporarily deployed to test October 4, 2022 22:39 Inactive
@helayoty helayoty temporarily deployed to test October 4, 2022 22:40 Inactive
@Fei-Guo Fei-Guo merged commit 042e2c4 into virtual-kubelet:master Oct 4, 2022
@helayoty helayoty deleted the aci-mocks branch October 4, 2022 23:08
@helayoty helayoty changed the title chore: ACI mocks refactor: ACI mocks Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

Assignees
No one assigned
Labels
kind/chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helayoty @Fei-Guo