refactor: Migrate ACI to Azure SDK v2 - Part 1 #422

helayoty · 2023-01-20T06:12:43Z

We mostly follow this guide for code migration:
https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/MIGRATION_GUIDE.md#pagination

Migrate ACI to Azure SDK v2 v2.2.0-beta.1
Use azureidentity library instead of adal

Signed-off-by: Heba Elayoty hebaelayoty@gmail.com

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

pkg/client/client_apis.go

pkg/client/extensions.go

pkg/tests/utils.go

pkg/validation/validator.go

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

codecov-commenter · 2023-01-20T20:20:49Z

Codecov Report

Merging #422 (fb72a69) into master (0c76852) will increase coverage by 0.37%.
The diff coverage is 59.69%.

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   42.91%   43.28%   +0.37%     
==========================================
  Files          50       50              
  Lines        5735     5829      +94     
==========================================
+ Hits         2461     2523      +62     
- Misses       3017     3050      +33     
+ Partials      257      256       -1

Impacted Files	Coverage Δ
pkg/network/aci_network.go	`25.92% <31.42%> (-0.61%)`	⬇️
pkg/auth/auth.go	`60.32% <44.68%> (-6.35%)`	⬇️
pkg/metrics/metrics.go	`75.18% <57.14%> (-1.56%)`	⬇️
pkg/provider/aci.go	`37.07% <59.61%> (+3.18%)`	⬆️
pkg/provider/aci_volumes.go	`45.19% <66.66%> (ø)`
pkg/provider/containergroup_to_pod.go	`75.39% <86.53%> (+0.11%)`	⬆️
pkg/analytics/analytics.go	`64.70% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pkg/provider/aci.go

pkg/network/aci_network.go

pkg/provider/aci.go

pkg/analytics/analytics.go

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

pkg/provider/aci.go

pkg/provider/containergroup_to_pod.go

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

pkg/provider/containergroup_to_pod.go

helayoty added the kind/refactor label Jan 20, 2023

helayoty requested a review from Fei-Guo as a code owner January 20, 2023 06:12

helayoty temporarily deployed to test January 20, 2023 06:12 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 20, 2023 06:13 — with GitHub Actions Inactive

Migrate ACI to Azure SDK v2

1158ba6

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

helayoty force-pushed the update-aci-sdk branch from d52fd59 to 1158ba6 Compare January 20, 2023 06:23

helayoty temporarily deployed to test January 20, 2023 06:23 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 20, 2023 06:24 — with GitHub Actions Inactive

Fei-Guo reviewed Jan 20, 2023

View reviewed changes

update import alias and fix pointers comments

ef1a4de

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

helayoty temporarily deployed to test January 20, 2023 19:40 — with GitHub Actions Inactive

helayoty requested a review from Fei-Guo January 20, 2023 19:41

fix UT point nil error

b98c666

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

helayoty temporarily deployed to test January 20, 2023 20:04 — with GitHub Actions Inactive

fix UT point nil error

9c301bf

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

helayoty temporarily deployed to test January 20, 2023 20:10 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 20, 2023 20:11 — with GitHub Actions Inactive

fix UT point nil error

85f6251

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

helayoty temporarily deployed to test January 20, 2023 20:15 — with GitHub Actions Inactive

Fei-Guo changed the title ~~refactor: Migrate ACI to Azure SDK v2~~ refactor: Migrate ACI to Azure SDK v2 - Part 1 Jan 20, 2023

helayoty temporarily deployed to test January 20, 2023 20:16 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 20, 2023 21:53 — with GitHub Actions Inactive

Fei-Guo reviewed Jan 20, 2023

View reviewed changes

Implement credential for client auth

9042a86

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

helayoty force-pushed the update-aci-sdk branch from 6d4c849 to 9042a86 Compare January 20, 2023 22:51

helayoty temporarily deployed to test January 20, 2023 22:51 — with GitHub Actions Inactive

helayoty requested a review from Fei-Guo January 23, 2023 17:18

helayoty temporarily deployed to test January 23, 2023 18:10 — with GitHub Actions Inactive

Fei-Guo reviewed Jan 23, 2023

View reviewed changes

pkg/provider/aci.go Show resolved Hide resolved

pkg/provider/containergroup_to_pod.go Outdated Show resolved Hide resolved

Add UT for getProbe and update start/last time

92035a5

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

helayoty temporarily deployed to test January 23, 2023 22:51 — with GitHub Actions Inactive

helayoty requested a review from Fei-Guo January 23, 2023 22:53

helayoty temporarily deployed to test January 23, 2023 23:12 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 23, 2023 23:20 — with GitHub Actions Inactive

move back the first/last time inside containerlist loop

ef04817

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

helayoty force-pushed the update-aci-sdk branch from d65fb7b to ef04817 Compare January 23, 2023 23:25

helayoty temporarily deployed to test January 23, 2023 23:25 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 23, 2023 23:26 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 24, 2023 00:22 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 24, 2023 00:23 — with GitHub Actions Inactive

helayoty force-pushed the update-aci-sdk branch from 9a162f4 to 01c10d7 Compare January 24, 2023 00:33

helayoty temporarily deployed to test January 24, 2023 00:33 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 24, 2023 00:34 — with GitHub Actions Inactive

validate instanceView state and provingingState

fb72a69

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>

helayoty force-pushed the update-aci-sdk branch from 01c10d7 to fb72a69 Compare January 24, 2023 01:54

helayoty temporarily deployed to test January 24, 2023 01:54 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 24, 2023 01:55 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 24, 2023 02:13 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 24, 2023 02:22 — with GitHub Actions Inactive

Fei-Guo approved these changes Jan 24, 2023

View reviewed changes

pkg/provider/containergroup_to_pod.go Outdated Show resolved Hide resolved

helayoty temporarily deployed to test January 24, 2023 02:39 — with GitHub Actions Inactive

helayoty temporarily deployed to test January 24, 2023 02:42 — with GitHub Actions Inactive

helayoty merged commit a628b01 into virtual-kubelet:master Jan 24, 2023

helayoty deleted the update-aci-sdk branch January 24, 2023 03:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Migrate ACI to Azure SDK v2 - Part 1 #422

refactor: Migrate ACI to Azure SDK v2 - Part 1 #422

helayoty commented Jan 20, 2023 •

edited

Loading

codecov-commenter commented Jan 20, 2023 •

edited

Loading

refactor: Migrate ACI to Azure SDK v2 - Part 1 #422

refactor: Migrate ACI to Azure SDK v2 - Part 1 #422

Conversation

helayoty commented Jan 20, 2023 • edited Loading

codecov-commenter commented Jan 20, 2023 • edited Loading

Codecov Report

helayoty commented Jan 20, 2023 •

edited

Loading

codecov-commenter commented Jan 20, 2023 •

edited

Loading