Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate network pkg to Azure SDK v2 - Part 3 #424

Merged
merged 5 commits into from
Jan 24, 2023

Conversation

helayoty
Copy link
Member

@helayoty helayoty commented Jan 23, 2023

We mostly follow this guide for code migration:
https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/MIGRATION_GUIDE.md

Signed-off-by: Heba Elayoty hebaelayoty@gmail.com

@helayoty helayoty temporarily deployed to test January 23, 2023 20:35 — with GitHub Actions Inactive
@helayoty helayoty mentioned this pull request Jan 23, 2023
3 tasks
@helayoty helayoty temporarily deployed to test January 23, 2023 20:35 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 03:33 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 03:33 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 03:36 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 03:36 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023

Codecov Report

Merging #424 (5882f1e) into master (0c76852) will decrease coverage by 0.07%.
The diff coverage is 46.24%.

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
- Coverage   42.91%   42.84%   -0.07%     
==========================================
  Files          50       50              
  Lines        5735     5879     +144     
==========================================
+ Hits         2461     2519      +58     
- Misses       3017     3104      +87     
+ Partials      257      256       -1     
Impacted Files Coverage Δ
pkg/network/aci_network.go 20.74% <8.73%> (-5.79%) ⬇️
pkg/auth/auth.go 60.32% <44.68%> (-6.35%) ⬇️
pkg/metrics/metrics.go 75.18% <57.14%> (-1.56%) ⬇️
pkg/provider/aci.go 36.78% <58.82%> (+2.88%) ⬆️
pkg/provider/aci_volumes.go 45.19% <66.66%> (ø)
pkg/provider/containergroup_to_pod.go 75.39% <86.53%> (+0.11%) ⬆️
pkg/analytics/analytics.go 64.70% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@helayoty helayoty temporarily deployed to test January 24, 2023 04:02 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 04:02 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 04:03 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 04:04 — with GitHub Actions Inactive
pkg/network/aci_network.go Outdated Show resolved Hide resolved
pkg/network/aci_network.go Outdated Show resolved Hide resolved
@helayoty helayoty temporarily deployed to test January 24, 2023 17:00 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 17:00 — with GitHub Actions Inactive
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test January 24, 2023 17:02 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 17:02 — with GitHub Actions Inactive
@helayoty helayoty requested a review from Fei-Guo January 24, 2023 17:02
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test January 24, 2023 17:19 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 17:20 — with GitHub Actions Inactive
pkg/network/aci_network.go Outdated Show resolved Hide resolved
pkg/network/aci_network.go Outdated Show resolved Hide resolved
@helayoty helayoty temporarily deployed to test January 24, 2023 17:47 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 17:47 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 18:56 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 18:56 — with GitHub Actions Inactive
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test January 24, 2023 19:03 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 19:04 — with GitHub Actions Inactive
pkg/provider/aci.go Outdated Show resolved Hide resolved
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test January 24, 2023 19:57 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test January 24, 2023 19:57 — with GitHub Actions Inactive
@helayoty helayoty requested a review from Fei-Guo January 24, 2023 20:00
@helayoty helayoty enabled auto-merge (squash) January 24, 2023 20:03
@helayoty helayoty requested a review from Fei-Guo January 24, 2023 20:03
@helayoty helayoty merged commit d17a4fd into virtual-kubelet:master Jan 24, 2023
@helayoty helayoty deleted the sdk-v2-migration branch January 24, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants