Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Pass k8s version as variable to e2e scripts #440

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

helayoty
Copy link
Member

@helayoty helayoty commented Feb 1, 2023

Update k8s-version to be configurable for both aks.sh and aks-addon.sh

The default value is 1.23.12

Signed-off-by: Heba Elayoty hebaelayoty@gmail.com

Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test February 1, 2023 01:58 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 1, 2023 01:58 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #440 (051defd) into master (0c76852) will decrease coverage by 0.15%.
The diff coverage is 43.80%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
- Coverage   42.91%   42.76%   -0.15%     
==========================================
  Files          50       50              
  Lines        5735     5874     +139     
==========================================
+ Hits         2461     2512      +51     
- Misses       3017     3106      +89     
+ Partials      257      256       -1     
Impacted Files Coverage Δ
pkg/network/aci_network.go 20.43% <7.74%> (-6.10%) ⬇️
pkg/auth/auth.go 60.32% <44.68%> (-6.35%) ⬇️
pkg/metrics/metrics.go 75.18% <57.14%> (-1.56%) ⬇️
pkg/provider/aci.go 36.56% <58.50%> (+2.67%) ⬆️
pkg/provider/aci_volumes.go 45.19% <66.66%> (ø)
pkg/provider/containergroup_to_pod.go 75.00% <85.71%> (-0.29%) ⬇️
pkg/analytics/analytics.go 64.70% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@helayoty helayoty merged commit cc5480c into virtual-kubelet:master Feb 1, 2023
@helayoty helayoty deleted the k8s-version-var branch February 1, 2023 02:23
helayoty added a commit that referenced this pull request Feb 7, 2023
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
helayoty added a commit that referenced this pull request Feb 10, 2023
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants