Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix image build version #448

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

helayoty
Copy link
Member

@helayoty helayoty commented Feb 9, 2023

  • Remove pull_request types from aks-e2e pipeline
  • Increase e2e timeout
  • Pass image version and timestamp to the dockerfile

Signed-off-by: Heba Elayoty hebaelayoty@gmail.com

@helayoty helayoty temporarily deployed to test February 9, 2023 04:38 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 04:38 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #448 (58b28e6) into master (0c76852) will increase coverage by 1.25%.
The diff coverage is 51.90%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   42.91%   44.16%   +1.25%     
==========================================
  Files          50       50              
  Lines        5735     5898     +163     
==========================================
+ Hits         2461     2605     +144     
- Misses       3017     3038      +21     
+ Partials      257      255       -2     
Impacted Files Coverage Δ
pkg/featureflag/feature_flag.go 75.00% <ø> (+20.00%) ⬆️
pkg/network/aci_network.go 20.43% <7.74%> (-6.10%) ⬇️
pkg/auth/auth.go 60.32% <44.68%> (-6.35%) ⬇️
pkg/metrics/metrics.go 75.18% <57.14%> (-1.56%) ⬇️
pkg/provider/aci_volumes.go 45.19% <70.58%> (ø)
pkg/provider/aci.go 45.79% <76.74%> (+11.90%) ⬆️
pkg/provider/containergroup_to_pod.go 75.00% <85.71%> (-0.29%) ⬇️
pkg/analytics/analytics.go 64.70% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@helayoty helayoty temporarily deployed to test February 9, 2023 04:50 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 18:13 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 18:16 — with GitHub Actions Inactive
@helayoty helayoty closed this Feb 9, 2023
@helayoty helayoty reopened this Feb 9, 2023
@helayoty helayoty temporarily deployed to test February 9, 2023 18:18 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 18:19 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 18:26 — with GitHub Actions Inactive
@helayoty helayoty closed this Feb 9, 2023
@helayoty helayoty reopened this Feb 9, 2023
@helayoty helayoty temporarily deployed to test February 9, 2023 18:27 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 18:27 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 18:37 — with GitHub Actions Inactive
@helayoty helayoty closed this Feb 9, 2023
@helayoty helayoty reopened this Feb 9, 2023
@helayoty helayoty temporarily deployed to test February 9, 2023 18:38 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 18:39 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 18:45 — with GitHub Actions Inactive
@helayoty helayoty closed this Feb 9, 2023
@helayoty helayoty closed this Feb 9, 2023
@helayoty helayoty reopened this Feb 9, 2023
@helayoty helayoty temporarily deployed to test February 9, 2023 19:12 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 19:12 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 19:32 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 19:46 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 20:02 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 20:05 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 20:13 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 20:29 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 20:35 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 20:51 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 21:03 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 21:22 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 21:30 — with GitHub Actions Inactive
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty temporarily deployed to test February 9, 2023 21:51 — with GitHub Actions Inactive
@helayoty helayoty closed this Feb 9, 2023
@helayoty helayoty reopened this Feb 9, 2023
@helayoty helayoty temporarily deployed to test February 9, 2023 21:51 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test February 9, 2023 21:52 — with GitHub Actions Inactive
@helayoty helayoty requested a review from Fei-Guo February 9, 2023 22:37
@helayoty helayoty enabled auto-merge (squash) February 9, 2023 23:48
@helayoty helayoty merged commit 616669d into virtual-kubelet:master Feb 10, 2023
helayoty added a commit that referenced this pull request Feb 10, 2023
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
@helayoty helayoty deleted the build-version branch February 10, 2023 14:52
helayoty added a commit that referenced this pull request Feb 10, 2023
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
helayoty added a commit that referenced this pull request Feb 10, 2023
Signed-off-by: Heba Elayoty <hebaelayoty@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants