Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrate from k8s.gcr.io to registry.k8s.io #484

Merged
merged 1 commit into from
Mar 13, 2023
Merged

fix: migrate from k8s.gcr.io to registry.k8s.io #484

merged 1 commit into from
Mar 13, 2023

Conversation

ahmedwaleedmalik
Copy link
Contributor

Kubernetes is migrating its image registry from k8s.gcr.io to registry.k8s.io.

Part of kubernetes/k8s.io#4780.

@helayoty
Copy link
Member

@ahmedwaleedmalik Thank you so much for your PR. Would you please update the rest of yaml test files in the same folder as well?

@ahmedwaleedmalik ahmedwaleedmalik temporarily deployed to test March 13, 2023 16:07 — with GitHub Actions Inactive
@ahmedwaleedmalik ahmedwaleedmalik temporarily deployed to test March 13, 2023 16:07 — with GitHub Actions Inactive
@ahmedwaleedmalik
Copy link
Contributor Author

@ahmedwaleedmalik Thank you so much for your PR. Would you please update the rest of yaml test files in the same folder as well?

Somehow I missed out on that, good catch.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023

Codecov Report

Merging #484 (ec4e4e7) into master (83819f8) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   45.63%   45.63%           
=======================================
  Files          15       15           
  Lines        2441     2441           
=======================================
  Hits         1114     1114           
  Misses       1243     1243           
  Partials       84       84           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@helayoty helayoty temporarily deployed to test March 13, 2023 16:49 — with GitHub Actions Inactive
@helayoty helayoty temporarily deployed to test March 13, 2023 16:49 — with GitHub Actions Inactive
Copy link
Member

@helayoty helayoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@helayoty helayoty enabled auto-merge (squash) March 13, 2023 17:29
@helayoty helayoty disabled auto-merge March 13, 2023 17:29
@helayoty helayoty merged commit caa9d1c into virtual-kubelet:master Mar 13, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the registry-update branch March 13, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants