Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: unit test for filterWindowsServiceAccountSecretVolume #497

Merged
merged 10 commits into from
Mar 28, 2023
Merged

test: unit test for filterWindowsServiceAccountSecretVolume #497

merged 10 commits into from
Mar 28, 2023

Conversation

smritidahal653
Copy link
Collaborator

@smritidahal653 smritidahal653 commented Mar 24, 2023 •
edited
Loading

Added unit test for filterWindowsServiceAccountSecretVolume. Also created unit test TestCreatePodWithWindowsOs which calls CreatePod method with the os set to "Windows"

@smritidahal653 smritidahal653 temporarily deployed to test March 24, 2023 22:09 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 24, 2023 22:09 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023 •
edited
Loading

Codecov Report

Merging #497 (3396a27) into master (c932764) will increase coverage by 0.97%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
+ Coverage   46.43%   47.41%   +0.97%     
==========================================
  Files          14       14              
  Lines        2455     2455              
==========================================
+ Hits         1140     1164      +24     
+ Misses       1229     1206      -23     
+ Partials       86       85       -1

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@smritidahal653 smritidahal653 temporarily deployed to test March 27, 2023 22:24 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 27, 2023 22:24 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 28, 2023 00:36 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 28, 2023 00:36 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 28, 2023 00:38 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 28, 2023 00:38 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 28, 2023 00:44 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 28, 2023 01:12 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 28, 2023 01:20 — with GitHub Actions Inactive
@Fei-Guo
Copy link
Collaborator

Fei-Guo commented Mar 28, 2023

LGTM

helayoty
helayoty reviewed Mar 28, 2023
View reviewed changes
pkg/provider/aci_test.go Outdated Show resolved Hide resolved
helayoty
helayoty reviewed Mar 28, 2023
View reviewed changes
pkg/provider/aci_test.go Outdated Show resolved Hide resolved
helayoty
helayoty reviewed Mar 28, 2023
View reviewed changes
pkg/provider/aci_test.go Outdated Show resolved Hide resolved
helayoty
helayoty requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@helayoty helayoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits but overall really LGTM.

@smritidahal653 smritidahal653 temporarily deployed to test March 28, 2023 02:44 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test March 28, 2023 02:44 — with GitHub Actions Inactive
helayoty
helayoty approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@helayoty helayoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@helayoty helayoty merged commit d6d00f4 into virtual-kubelet:master Mar 28, 2023
@smritidahal653 smritidahal653 mentioned this pull request Mar 29, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helayoty helayoty helayoty approved these changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo Fei-Guo is a code owner

Assignees
No one assigned
Labels
kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smritidahal653 @codecov-commenter @Fei-Guo @helayoty