Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added unit test for getVolumes method for getting Secret Volume in aci_volumes #499

Merged
merged 7 commits into from
Mar 28, 2023

Conversation

nidhunge
Copy link
Contributor

Added unit test for getVolumes method for getting Secret Volume in aci_volumes file implemented in aci_volumes_test.go

Issue Link: #498

@nidhunge nidhunge temporarily deployed to test March 28, 2023 00:43 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test March 28, 2023 00:43 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2023

Codecov Report

Merging #499 (ca8f471) into master (c932764) will increase coverage by 0.69%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   46.43%   47.12%   +0.69%     
==========================================
  Files          14       14              
  Lines        2455     2455              
==========================================
+ Hits         1140     1157      +17     
+ Misses       1229     1212      -17     
  Partials       86       86              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nidhunge nidhunge temporarily deployed to test March 28, 2023 00:48 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test March 28, 2023 01:13 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test March 28, 2023 01:23 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test March 28, 2023 01:28 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test March 28, 2023 01:28 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test March 28, 2023 16:38 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test March 28, 2023 16:38 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test March 28, 2023 16:41 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test March 28, 2023 16:43 — with GitHub Actions Inactive
@Fei-Guo
Copy link
Collaborator

Fei-Guo commented Mar 28, 2023

LGTM

@nidhunge nidhunge temporarily deployed to test March 28, 2023 17:03 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test March 28, 2023 17:04 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test March 28, 2023 17:13 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test March 28, 2023 17:14 — with GitHub Actions Inactive
Copy link
Member

@helayoty helayoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nidhunge nidhunge merged commit bc92cae into virtual-kubelet:master Mar 28, 2023
smritidahal653 pushed a commit to smritidahal653/azure-aci that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants