test: Add Unit Test for GetVolumes (ProjectedVolume) with source secret #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #505 +/- ##
==========================================
+ Coverage 51.03% 51.48% +0.44%
==========================================
Files 14 14
Lines 2455 2455
==========================================
+ Hits 1253 1264 +11
+ Misses 1113 1100 -13
- Partials 89 91 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
helayoty
changed the title
|
LGTM |
4 tasks
helayoty
changed the title
helayoty
approved these changes
Mar 30, 2023
helayoty
approved these changes
Mar 30, 2023
helayoty
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit test for Projected volumes in GetVolumes method with Secret source inside aci_volumes.go in aci_volumes_test.go test file.
Changed mock variable names for GetVolumes case secret to more realistic values.
#500