Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added unit test for getImagePullSecrets with docker config JSON #512

Merged
merged 2 commits into from
Apr 3, 2023
Merged

test: added unit test for getImagePullSecrets with docker config JSON #512

merged 2 commits into from
Apr 3, 2023

Conversation

smritidahal653
Copy link
Collaborator

added unit test for getImagePullSecrets in aci.go with dockerc config JSON secret.

@smritidahal653 smritidahal653 temporarily deployed to test April 3, 2023 19:15 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test April 3, 2023 19:15 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 changed the title added unit test for getImagePullSecrets with docker config JSON test: added unit test for getImagePullSecrets with docker config JSON Apr 3, 2023
@smritidahal653 smritidahal653 mentioned this pull request Apr 3, 2023
Closed
8 tasks
Fei-Guo
Fei-Guo reviewed Apr 3, 2023
View reviewed changes
pkg/provider/aci_test.go Outdated Show resolved Hide resolved
@smritidahal653 smritidahal653 temporarily deployed to test April 3, 2023 20:41 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test April 3, 2023 20:41 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #512 (7559633) into master (06f2c4e) will increase coverage by 1.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
+ Coverage   53.97%   54.98%   +1.01%     
==========================================
  Files          14       14              
  Lines        2455     2455              
==========================================
+ Hits         1325     1350      +25     
+ Misses       1038     1012      -26     
- Partials       92       93       +1

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Fei-Guo
Fei-Guo reviewed Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helayoty helayoty merged commit 593f287 into virtual-kubelet:master Apr 3, 2023
@smritidahal653 smritidahal653 deleted the unitTestCoverage branch April 3, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo left review comments

@helayoty helayoty helayoty approved these changes

Assignees
No one assigned
Labels
kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smritidahal653 @codecov-commenter @helayoty @Fei-Guo