Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added Unit Test for real_time/calculateUsageNanoCores #515

Merged
merged 16 commits into from
Apr 5, 2023

Conversation

nidhunge
Copy link
Contributor

@nidhunge nidhunge commented Apr 4, 2023

Created real_time_test.go and added Unit Test for calculateUsageNanoCores in real_time.go under real_time_test.go

Issue Link: #514

@nidhunge nidhunge temporarily deployed to test April 4, 2023 19:53 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test April 4, 2023 19:53 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Merging #515 (ce3708a) into master (8374667) will increase coverage by 1.21%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   56.74%   57.95%   +1.21%     
==========================================
  Files          14       14              
  Lines        2455     2469      +14     
==========================================
+ Hits         1393     1431      +38     
+ Misses        968      939      -29     
- Partials       94       99       +5     
Impacted Files Coverage Δ
pkg/metrics/real_time.go 22.94% <100.00%> (+20.37%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nidhunge nidhunge temporarily deployed to test April 4, 2023 22:49 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test April 4, 2023 22:49 — with GitHub Actions Inactive
@nidhunge nidhunge mentioned this pull request Apr 4, 2023
8 tasks
@nidhunge nidhunge temporarily deployed to test April 5, 2023 01:55 — with GitHub Actions Inactive
@nidhunge nidhunge temporarily deployed to test April 5, 2023 01:55 — with GitHub Actions Inactive
Copy link
Collaborator

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helayoty helayoty changed the title test: Created real_time_test.go and added Unit Test for calculateUsageNanoCores test: added Unit Test for real_time/calculateUsageNanoCores Apr 5, 2023
@nidhunge nidhunge enabled auto-merge (squash) April 5, 2023 16:51
@nidhunge nidhunge merged commit 29196ef into virtual-kubelet:master Apr 5, 2023
@nidhunge nidhunge deleted the ndNetworksetupUT branch April 5, 2023 18:15
@nidhunge nidhunge mentioned this pull request Apr 5, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants