Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added unit test for cleanupDanglingPods #516

Merged
merged 10 commits into from
Apr 6, 2023

Conversation

smritidahal653
Copy link
Collaborator

added unit test for cleanupDanglingPods in podsTracker.go

  • test case: podLister returns an additional pod than what is reported by the client so the dangling pod is deleted so the two are in sync

@smritidahal653 smritidahal653 temporarily deployed to test April 5, 2023 19:26 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test April 5, 2023 19:26 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test April 5, 2023 21:00 — with GitHub Actions Inactive
helayoty
helayoty previously approved these changes Apr 5, 2023
Copy link
Member

@helayoty helayoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

@smritidahal653 smritidahal653 dismissed helayoty’s stale review April 5, 2023 21:34

Working on removing podTracker2 as per Fei's review

@smritidahal653 smritidahal653 temporarily deployed to test April 5, 2023 23:21 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test April 5, 2023 23:21 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test April 6, 2023 18:46 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test April 6, 2023 18:46 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test April 6, 2023 18:47 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test April 6, 2023 18:47 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

Merging #516 (acaf9d1) into master (81010aa) will increase coverage by 1.66%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
+ Coverage   58.28%   59.94%   +1.66%     
==========================================
  Files          14       14              
  Lines        2469     2469              
==========================================
+ Hits         1439     1480      +41     
+ Misses        929      880      -49     
- Partials      101      109       +8     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Fei-Guo Fei-Guo merged commit 6a71dd9 into virtual-kubelet:master Apr 6, 2023
@smritidahal653 smritidahal653 deleted the unitTestCoverage branch April 6, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants