Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make aci fail-fast creating pods with lifecycle hooks #548

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

hypnoce
Copy link
Contributor

@hypnoce hypnoce commented May 24, 2023

No description provided.

@hypnoce hypnoce temporarily deployed to test May 24, 2023 07:13 — with GitHub Actions Inactive
@hypnoce hypnoce temporarily deployed to test May 24, 2023 07:13 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #548 (beaf97b) into master (acb2ed1) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
+ Coverage   68.21%   68.48%   +0.26%     
==========================================
  Files          15       15              
  Lines        2561     2573      +12     
==========================================
+ Hits         1747     1762      +15     
+ Misses        697      695       -2     
+ Partials      117      116       -1     
Impacted Files Coverage Δ
pkg/provider/aci.go 68.12% <100.00%> (+0.72%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@helayoty helayoty enabled auto-merge (squash) June 1, 2023 17:05
@helayoty
Copy link
Member

helayoty commented Jun 5, 2023

PR got approved. Please update the branch with the master to be able to complete the merge.

auto-merge was automatically disabled June 5, 2023 15:21

Head branch was pushed to by a user without write access

@hypnoce
Copy link
Contributor Author

hypnoce commented Jun 5, 2023

PR got approved. Please update the branch with the master to be able to complete the merge.

@helayoty done

@helayoty helayoty temporarily deployed to test June 5, 2023 16:18 — with GitHub Actions Inactive
@helayoty helayoty enabled auto-merge (squash) June 5, 2023 16:18
@helayoty helayoty temporarily deployed to test June 5, 2023 16:18 — with GitHub Actions Inactive
@helayoty helayoty merged commit a2d398f into virtual-kubelet:master Jun 5, 2023
@helayoty helayoty added this to the 1.6.0 milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants