magento#12294: Bug: Adding Custom Attribute - The value of Admin scop…

…e can't be empty
virtual97 · Jan 2, 2018 · e78ea61 · e78ea61
1 parent 288d0d4
commit e78ea61
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml b/app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/attribute/options.phtml
@@ -57,7 +57,7 @@ $stores = $block->getStoresSortedBySortOrder();
  <input type="hidden" id="option-count-check" value="" />
  </div>
  <script id="row-template" type="text/x-magento-template">
-  <tr>
+ <tr <% if (data.rowClasses) { %>class="<%- data.rowClasses %>"<% } %>>
  <td class="col-draggable">
  <?php if (!$block->getReadOnly() && !$block->canManageOptionDefaultOnly()): ?>
  <div data-role="draggable-handle" class="draggable-handle"

diff --git a/app/code/Magento/Catalog/view/adminhtml/web/js/options.js b/app/code/Magento/Catalog/view/adminhtml/web/js/options.js
@@ -24,6 +24,7 @@ define([
  totalItems: 0,
  rendered: 0,
  template: mageTemplate('#row-template'),
+ newOptionClass: 'new-option',
  isReadOnly: config.isReadOnly,
  add: function (data, render) {
  var isNewOption = false,
@@ -32,7 +33,8 @@ define([
  if (typeof data.id == 'undefined') {
  data = {
  'id': 'option_' + this.itemCount,
- 'sort_order': this.itemCount + 1
+ 'sort_order': this.itemCount + 1,
+ 'rowClasses': this.newOptionClass
  };
  isNewOption = true;
  }
@@ -81,12 +83,13 @@ define([
  element.addClassName('no-display');
  element.addClassName('template');
  element.hide();
- jQuery(element).find('input').each(function(index, el) {
- el.disabled = 'disabled';
- });
  this.totalItems--;
  this.updateItemsCountField();
  }
+
+ if (element.hasClassName(this.newOptionClass)) {
+ element.remove();
+ }
  },
  updateItemsCountField: function () {
  $('option-count-check').value = this.totalItems > 0 ? '1' : '';