Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing structure_list2 decoder test #22

Closed
wants to merge 3 commits into from
Closed

Add failing structure_list2 decoder test #22

wants to merge 3 commits into from

Conversation

link2xt
Copy link

@link2xt link2xt commented Jan 31, 2017

Test passes if added into official https://github.com/hashicorp/hcl
decoder test.

What pyhcl makes is obviously wrong:
{'top': [{'a': 'a', 'b': 'b', 'c': 'c'}, {'b': 'b'}]} != {'top': [{'a': 'a', 'b': 'b'}, {'b': 'b', 'c': 'c'}]}

No solution yet, but looks like the problematic code was added in 46a4138

The code erroneously adds 'c' into the first dictionary, but then discovers 'b' that already exists and extends the list, so the 'c' key appears moved to the first dictionary.

Travis CI will likely fail this one, but please merge it in.

@virtuald
Copy link
Owner

If someone pushes a PR to fix the failing test, I'm happy to merge it. I'll keep the PR open, but I don't personally have bandwidth to address it. Maybe @scottbelden ?

@link2xt
Copy link
Author

link2xt commented Feb 2, 2017

Fixed structure_list2 test with a fairly straightforward fix, but added structure_list3

@virtuald virtuald deleted the branch virtuald:master September 1, 2023 04:56
@virtuald virtuald closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants