Fix: non-blocking ChannelTransferProgress handling #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32.
In the current implementation,
time.Sleep(50 * time.Millisecond)
is called whenever aChannelTransferProgress
event is triggered, and the channel handling these events is unbuffered. This setup causes the reader/writer processes to be blocked, subsequently slowing down both upload and download speeds.This pull request proposes a solution by leveraging the built-in throttle feature of the progressBar instead of using
time.Sleep
.Possibility of a Non-blocking Send
Actually, integrating the progressBar's throttle feature introduces overhead due to various checks and locks. An alternative improvement could be the implementation of non-blocking sends, which might further enhance performance:
However, this change in the SDK could potentially lead to some issues and may break other SDK users. For instance, the last progress update might be dropped, which could result in an incomplete progress bar display: