Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AggregationLayers: Update and improve unit test coverage. #4046

Merged
merged 4 commits into from
Dec 18, 2019
Merged

AggregationLayers: Update and improve unit test coverage. #4046

merged 4 commits into from
Dec 18, 2019

Conversation

1chandu
Copy link
Contributor

@1chandu 1chandu commented Dec 18, 2019 •
edited
Loading

For ##3844

Background

  • Fixes
    • Fix accessor settings in ScreenGrid and Contour Layers (not applicable for other layers)
  • Tests
    • Update unit tests for GridAggregationLayer, and enable it for Node.
    • Clean up aggregation-data file
    • Add new unit tests for CPU and GPU Aggregators (Screen and World space aggregation)
    • Add new tests for util methods.

Change List

@coveralls
Copy link

coveralls commented Dec 18, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 83.367% when pulling 09bc65f on AggregationFlags_Tests into 911eff1 on AggregationFlags.

@1chandu 1chandu mentioned this pull request Dec 18, 2019
Merged
@1chandu 1chandu force-pushed the AggregationFlags_Tests branch from 09bc65f to 96cb589 Compare December 18, 2019 23:23
@1chandu 1chandu changed the title [Not ready yet] AggregationLayers: Update and improve unit test coverage. AggregationLayers: Update and improve unit test coverage. Dec 18, 2019
@1chandu 1chandu changed the base branch from AggregationFlags to master December 18, 2019 23:27
@1chandu 1chandu force-pushed the AggregationFlags_Tests branch from 96cb589 to e7b26ee Compare December 18, 2019 23:29
@1chandu 1chandu merged commit 6899940 into master Dec 18, 2019
@1chandu 1chandu deleted the AggregationFlags_Tests branch December 18, 2019 23:42
chrisgervang pushed a commit that referenced this pull request Jan 31, 2020
@1chandu @chrisgervang
AggregationLayers: Update and improve unit test coverage. (#4046)
2fe4a20 
* AggregationTests: cleanup test-data, add world/screen space tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1chandu @coveralls @Pessimistress