Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid crash when a deck object already exists in the global scope #4070

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Avoid crash when a deck object already exists in the global scope #4070

merged 1 commit into from
Dec 23, 2019

Conversation

Pessimistress
Copy link
Collaborator

For #4069

@tsherif Same change needs to be made to luma.gl.

Change List

  • Avoid crash if a deck object already exists in the global scope.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 80.866% when pulling bfad0e6 on x/init-fix into 4f02eb9 on master.

@Pessimistress Pessimistress merged commit d9e7859 into master Dec 23, 2019
@Pessimistress Pessimistress deleted the x/init-fix branch December 23, 2019 19:42
Pessimistress added a commit that referenced this pull request Dec 23, 2019
@Pessimistress
improve version detection (#4070)
9d18a4a
Pessimistress added a commit that referenced this pull request Dec 24, 2019
@Pessimistress
improve version detection (#4070)
3136bca
chrisgervang pushed a commit that referenced this pull request Jan 31, 2020
@Pessimistress @chrisgervang
improve version detection (#4070)
8a3c41b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xintongxia xintongxia xintongxia approved these changes

@tsherif tsherif Awaiting requested review from tsherif

@1chandu 1chandu Awaiting requested review from 1chandu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @xintongxia